Add: AllowAnanymousIps to server settings #225
Conversation
…us connections even if PermittedIps is null or empty
|
Hi @harpm I appreciate the contribution to the project. I'm a little unsure of how to proceed with it. The intent of the permitted IP list is to specify who can connect. If it's set, it's checked. If it's not, it isn't checked. This seems like a bypass for a very specific use case and I don't know that it would be widely applicable to others. |
First of all thank you for putting time on reviewing my pull request and my issue; the problem with the old approach is that for the time that we need to prevent any anonymous connection for security reasons the only thing I can do is to add a fake IpPort to the permitted list that reduces my codes readability and also in the near future someone else may work on that code and know nothing about the reason I did this, in addition somewhere else in the code someone may clear the list for other logic or business and this may create side-effects and conflict between these parts of code. |
…se with AllowAnonymous flag you need to change the setting PermitType property
|
Hello again @jchristn |
Added Flag AllowAnanymousIPs to the SimpleTcpServerSettings in order to prevent anonymous connections even when PermittedIPs list is null or empty when needed.
scenario:
- Sometimes we need to prevent all connections but PermittedIPs for security reasons and PermittedIPs are still empty, So there must be a flag that prevent connections in this scenario
- Also there is a time we have some PermittedIPs but we don't need to prevent new connections, again we need a flag for this exceptional scenario