Introduce dynamic versioning with gen-build-version.sh #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates version strings from the latest Git commit hash when inside a Git work tree, or from .tarball-version when building from a release archive. With the --dist option, omits the commit hash for distribution builds. Automatically generates .tarball-version during 'make dist' and includes it in the tarball.
Closed
|
英語が苦手なので日本語で失礼します。 で良いのでは。 |
Simplifies version generation by replacing separate git commands with a single git log call. Also adds OUTPUT_FOR_DIST flag.
…cible builds - dist-hook now forcibly regenerates .tarball-version using gen-build-version.sh --dist, ensuring consistent PACKAGE_VERSION for distribution builds. - Invokes autoconf with --force to always update configure script during dist. - Moves .tarball-version generation logic directly into dist-hook for clarity. - gen-build-version.sh prioritizes existing non-empty .tarball-version early for reproducibility. - gen-build-version.sh now checks for non-empty .tarball-version early using `-s`, to avoid mistakenly using an empty file that may briefly exist during `make dist`.
This improves clarity, reproducibility, and avoids issues where an empty `.tarball-version` file might be created and read within the same `make dist` process. - Add `-o <file>` option to write the generated version string directly to the specified file, replacing the use of shell redirection (`> .tarball-version`) in Makefile. - Suppress stdout when `-o` is used to avoid duplicate or premature outputs. - Restore fallback to `.tarball-version` only when `-o` is not specified and no Git info is available. - Extract version output logic into a unified `output_version` function. - Move Git working tree checks into `check_git_clean_for_dist` helper for --dist validation. - Update `Makefile.am` to use `-o .tarball-version`, preventing race conditions where an empty `.tarball-version` file might be created and read within the same `make dist` process.
|
英語は全部chatgptですwいい時代になりました |
…option to gen-build-version.sh - Modified `configure.ac` to allow the build to proceed without breaking even if there are uncommitted changes. - Added the `--verify` option to check if the Git repository is clean before generating the version string, only when the option is specified. - Updated `dist-hook` in `Makefile.am` to include the `--verify` option.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates version strings from the latest Git commit hash when inside a Git work tree, or from .tarball-version when building from a release archive. With the --dist option, omits the commit hash for distribution builds. Automatically generates .tarball-version during 'make dist' and includes it in the tarball.