[JAX SC] Fix unique ID count propagation in minibatching splits and update test assertion. #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_822378220
branch
3 times, most recently
from
91da13e to
6075692
Compare
…pdate test assertion. In `minibatching_splits_impl.h`, when a split is made, the unique ID count for the parent bucket should be updated to the maximum of the two child buckets. In `input_preprocessing_test.cc`, change a conditional check to an assertion, as `INT_MAX` is used as a sentinel and should not appear in valid embedding IDs. PiperOrigin-RevId: 822775808
copybara-service
bot
force-pushed
the
test_822378220
branch
from
6075692 to
2121dbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JAX SC] Fix unique ID count propagation in minibatching splits and update test assertion.
In
minibatching_splits_impl.h, when a split is made, the unique ID count for the parent bucket should be updated to the maximum of the two child buckets. Ininput_preprocessing_test.cc, change a conditional check to an assertion, asINT_MAXis used as a sentinel and should not appear in valid embedding IDs.