Refactor trading bot into a modular package structure. #1679
+4,271
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This major refactoring addresses several architectural issues in the original script to improve maintainability, testability, and robustness. Key changes include: - Decomposed the single monolithic script into a Python package (`trading_bot_app`) with distinct modules for UI, IBKR client, strategy, ML management, indicators, and configuration. - Decoupled the core strategy logic from the `tkinter` UI by refactoring the configuration class to be a pure data container. - Corrected the parameter handling mechanism in the backtesting strategy to be compatible with the `backtesting.py` library. - Added a `requirements.txt` file to manage all third-party dependencies. - Created a verification test (`test_refactor.py`) to ensure the new modular structure is sound and all components are importable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This major refactoring addresses several architectural issues in the original script to improve maintainability, testability, and robustness.
Key changes include:
trading_bot_app) with distinct modules for UI, IBKR client, strategy, ML management, indicators, and configuration.tkinterUI by refactoring the configuration class to be a pure data container.backtesting.pylibrary.requirements.txtfile to manage all third-party dependencies.test_refactor.py) to ensure the new modular structure is sound and all components are importable.