Test #19
Test #19
Conversation
Added pendulum length equation.
There was a problem hiding this comment.
Thanks @eliotjkim for opening a pull request.
The length equation looks great, and the addition of a constant is useful - though it should be updated in all equations.
I also note that you have opened a PR from your main branch rather than a 'length-equation' feature branch, so it has brought in commits with your gitignore and conflicting LICENSE which could be avoided using branches. These should be removed from this PR.
Finally, it would be good to include a description on the Pull Request, and link to note that it closes #9
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| g = 9.81 # meters per second^2 | |||
There was a problem hiding this comment.
This is is a useful improvement, though note we usually use capitals for constants in Python:
I suggest the following, though the rest of the code needs updating.
| g = 9.81 # meters per second^2 | |
| GRAV = 9.81 # meters per second^2 |
Test