Skip to content

Conversation

SAKSHaTHOR
Copy link

No description provided.

@jaspal007
Copy link
Owner

Nice work @SAKSHaTHOR ! 🎊
I really appreciate your thought process you applied for filtering the data. 😎

Issues with the commit

Use of Json file

Now what I really wanted you to do was do the processing on the data from the json file itself.
Sure, the data for this assignment was too short so hard coding that data in your user defined class was quite a smart move!
Now lets imagine a situation where this data is in 100s or even 1000s lines of code. To make things even worse, what if the data is DYNAMIC , changes all the time...
You see in these cases hard coding the data is not going to work for too long.
So try to fetch data from json file itself using different properties of maps and keys and values.

Updating the readme.md file

  • Update the README.md file that is created along with the new flutter project and not the readme file that I have created.

  • So try to re allocate your assets within the project folder.

  • Restore all the commits to the readme file with the command git restore ../sample.json

@jaspal007
Copy link
Owner

@SAKSHaTHOR please revoke the changes your made in the main README.md file using git restore ../sample.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants