-
Notifications
You must be signed in to change notification settings - Fork 15
Add automatic transforms #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@Kucharssim I cannot reproduce the results from Minitab. There seem to be two points here:
![]()
Let me know if I can support you with this! |
Thanks for checking! Summary of the changes since your testing:
I've also added the Johnson transform (not to be confused with Yeo-Johnson: different methods!) that is also apparently provided by Minitab. The two implementations will probably differ though (Minitab uses different criterion for selecting the optimal parameters of the transform than the original paper). As far as I can see in the docs, this transform is only used within Minitab to tranform the data regardless of the data subgroups. The function also returns some additional info in the attributes, which will be useful for integrating this transform in the process capability study analysis. jasp-stats/jasp-desktop#6000 needs to reflect the recent changes but this PR is ready for review again. |
@Kucharssim I can reproduce the Lambda calculations now. However, there is another step in the transformation in Minitab that I missed. Minitab also usually rounds the Lambda that is used for the transformation. So while the unrounded Lambda matches, the transformed data do not yet match. You can find the details here: https://support.minitab.com/en-us/minitab/help-and-how-to/quality-and-process-improvement/control-charts/how-to/box-cox-transformation/interpret-the-results/key-results/. For this, CIs for Lambda are needed and I could not find any information on how to calculate these on the Minitab website. As you pointed out the Johnson transformation differs in results from Minitab. Not sure which implementation is better, but would it be feasible to also have a version that emulates Minitab? |
Part of a fix for Gitea SGC#15 and prerequisite for Gitea SGC#6
@JTPetter: For the Box-Cox, I added an option to estimate lambda as described in the Minitab manual: https://support.minitab.com/en-us/minitab/help-and-how-to/quality-and-process-improvement/control-charts/how-to/box-cox-transformation/methods-and-formulas/methods-and-formulas/. But I don't have Minitab. Would it be possible to check whether this implementation indeed gives similar results (there will always probably be some small numerical differences though)?