-
-
Notifications
You must be signed in to change notification settings - Fork 215
some filter improvements #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some filter improvements #5378
Conversation
ad95625
to
1027b4f
Compare
Maybe it is clear in context. For me, right now, I am a little confused about the following: |
@EJWagenmakers here, some context: |
Is the drag-and-drop filter also a non-R filter? |
Yes |
3c443a7
to
89610f5
Compare
…s/jasp-issues#2515 (comment) ctrl/cmd+enter should run r code also adds is.na to constructors just replace the DEFAULT_FILTER define with the correct function calls and see what happens make filter error show up again... fix statusbar jasp-stats/INTERNAL-jasp#2462 slightly less computersciency tooltip
1027b4f
to
d0a92d8
Compare
Would be cool if it could be explained like this: Or just stick to one of the three, if possible. Becaus it is confusing to have 3 names for the same thing here. |
How about
|
Yes, this is very clear! |
Haha ok nice |
Ill see how hard it is to get the comment highlighted as comment |
Also use code font and better readability for generatedFilter
The text will now look like (as suggested in jasp-stats/jasp-issues#2515 (comment)):
What do you think @EJWagenmakers @JohnnyDoorn ?
It is now also translatable, which it wasnt before.
This PR also fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2462 in that the statusbar now gives sensible feedback. It also is translatable now.
I was also annoyed that I couldnt run rcode in the filter and computed column windows by pressing ctrl/cmd+return.
So I added that too
And then there was the fact that filtererrors were being ignored by the desktop... This is now also fixed.
For the kicker I also added the
is.na
function to the filter/compcolconstructor function lists as suggested in jasp-stats/jasp-issues#2493