Upgrade to .NET 8 and replace ILMerge with single-file deployment #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Funny I just ported the soft to .NET 8.0 few minutes ago... and found your PR when wanting to submit mine (just in case it would be useful for someone else) 😆 @CodingMarco you might want to have a look at my comment here too to fix the behavior of the program: #2 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did what the title says in an upstreamable manner (at least I hope so).
Also, I updated the NuGet package versions.
By upgrading to .NET 8, we can make the tool cross-platform, and also we can simplify the build process by using single-file deployment instead of ILMerge.
I decided to not use a self-contained build (.NET 8.0 runtime will be required) but this decision can be discussed.
A possible future improvement could be to add a GitHub Action that builds the executables for Windows and Linux.
Solves #3