Issue-229 fix play-by-play timestamp parsing #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that basketball-reference now has an empty string as the 'aria-label' for `<tr class="thead" >` header rows. This change allows these header rows to be skipped as they do not contain any play-by-play data - i.e. `has_play_by_play_data()` should be `False`.
Includes: - change regex for team names (page html has changed). - Extend logic for has_play_by_play_data to exclude rows at zero timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that basketball-reference now has an empty string as the 'aria-label' for
<tr class="thead" >header rows. This change allows these header rows to be skipped as they do not contain any play-by-play data - i.e.has_play_by_play_data()should beFalse.