Pessimize match-conditional-to-when slightly
#612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfirth
added
the
existing lint
There was a problem hiding this comment.
Pull Request Overview
This PR refines the match-conditional-to-when refactoring rule by adding constraints to prevent it from triggering on conditionals with short body expressions. The rule now only suggests converting if and cond expressions to #:when clauses when the body expressions are sufficiently long or complex.
- Added logic to check body expression length and span before applying the refactoring
- Updated existing tests to use longer expressions that still trigger the rule
- Added new negative test cases to verify short conditionals are not refactored
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| default-recommendations/match-shortcuts.rkt | Added conditional checks to prevent refactoring when body expressions are short |
| default-recommendations/match-shortcuts-test.rkt | Updated existing tests with longer expressions and added negative test cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't like the look of this rule's changes in herbie-fp/herbie#1401.