Skip to content

RenderContext: code cleanup #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RenderContext: code cleanup #2487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eaa185
Update RenderContext.java
capdevon Jun 11, 2025
5b6824c
Update RenderContext.java: typo
capdevon Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions jme3-core/src/main/java/com/jme3/renderer/RenderContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2009-2024 jMonkeyEngine
* Copyright (c) 2009-2025 jMonkeyEngine
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -38,6 +38,8 @@
import com.jme3.texture.FrameBuffer;
import com.jme3.texture.Image;
import java.lang.ref.WeakReference;
import java.util.Arrays;

import com.jme3.shader.bufferobject.BufferObject;

/**
Expand Down Expand Up @@ -216,13 +218,12 @@ public class RenderContext {
public FrameBuffer boundFB;

/**
* Currently bound Renderbuffer.
* Currently bound RenderBuffer.
*
* @see Renderer#setFrameBuffer(com.jme3.texture.FrameBuffer)
*/
public int boundRB;


/**
* Currently bound element array vertex buffer.
*
Expand Down Expand Up @@ -259,15 +260,13 @@ public class RenderContext {
*
* @see Renderer#setTexture(int, com.jme3.texture.Texture)
*/
public final WeakReference<Image> boundTextures[]
= new WeakReference[maxTextureUnits];

public final WeakReference<Image>[] boundTextures = new WeakReference[maxTextureUnits];

/**
* Current bound buffer object IDs for each buffer object unit.
*
* @see Renderer#setUniformBufferObject(int, com.jme3.shader.BufferObject)
* @see Renderer#setShaderStorageBufferObject(int, com.jme3.shader.BufferObject)
* @see Renderer#setUniformBufferObject(int, com.jme3.shader.bufferobject.BufferObject)
* @see Renderer#setShaderStorageBufferObject(int, com.jme3.shader.bufferobject.BufferObject)
*/
public final WeakReference<BufferObject>[] boundBO = new WeakReference[maxBufferObjectUnits];

Expand Down Expand Up @@ -364,9 +363,7 @@ public RenderContext() {
init();
}


private void init() {
cullMode = RenderState.FaceCullMode.Off;
depthTestEnabled = false;
depthWriteEnabled = true;
colorWriteEnabled = true;
Expand Down Expand Up @@ -421,16 +418,10 @@ private void init() {
public void reset() {
init();

for (int i = 0; i < boundTextures.length; i++) {
boundTextures[i] = null;
}

Arrays.fill(boundTextures, null);
textureIndexList.reset();

for (int i = 0; i < boundAttribs.length; i++) {
boundAttribs[i] = null;
}

Arrays.fill(boundAttribs, null);
attribIndexList.reset();
}
}