Skip to content

Conversation

@TYZRPVX
Copy link

@TYZRPVX TYZRPVX commented Mar 2, 2023

Fixed UpdateBuilder.update() / DeleteBuilder.delete() always return 0 when WAL enabled

  1. The root cause is the same as referred in Fixed update always return 0 when sqlite WAL enabled #131
  2. Maybe reflection is necessary, execSQL returns void, but executeSql returns correct value
  3. Calling methods in a compatible way has been verified and correctness is guaranteed, if executeSql failed, call execSQL

Thanks for reviewing this PR

@j256
Copy link
Owner

j256 commented Mar 7, 2023

Thanks for this. Submitted a couple of things for consideration.

@TYZRPVX
Copy link
Author

TYZRPVX commented Mar 10, 2023

@j256 May you review again, thanks for the efforts

@TYZRPVX TYZRPVX requested a review from j256 April 21, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants