Skip to content

Conversation

@ivanklee86
Copy link
Owner

@ivanklee86 ivanklee86 commented Sep 29, 2025

  • Build own devcontainer so we can set Go version
  • Update to Go 1.24.7 and general dependency updates.
  • Remember how everything works again!

Copilot AI review requested due to automatic review settings September 29, 2025 09:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to use ArgoCD v3 and Go 1.24.7, along with updating various dependencies and development environment configurations.

  • Upgrade from ArgoCD v2 to v3 including API and package changes
  • Update Go version from 1.23.2 to 1.24.7 with new toolchain configuration
  • Modernize development container setup with new base image and Node.js installation method

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/argocd/wrapper.go Updates ArgoCD package import from v2 to v3
internal/argocd/results.go Updates ArgoCD imports and changes HealthStatus to AppHealthStatus
internal/argocd/client_test.go Updates ArgoCD package import for test file
internal/argocd/client.go Updates multiple ArgoCD package imports from v2 to v3
integration/kubernetes/argocd/Chart.yaml Upgrades argo-cd chart version from 7.8.23 to 8.5.0
go.mod Updates Go version, adds toolchain, and upgrades numerous dependencies
.devcontainer/post_install.sh Adds --clear flag to uv venv command
.devcontainer/Dockerfile Refactors container setup with new base image and Go installation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

Test Results

70 tests  ±0   70 ✅ ±0   11s ⏱️ -1s
 6 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e7cce87. ± Comparison against base commit c922e6e.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.37%. Comparing base (c922e6e) to head (e7cce87).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   68.45%   69.37%   +0.92%     
==========================================
  Files          12       12              
  Lines         951      774     -177     
==========================================
- Hits          651      537     -114     
+ Misses        300      237      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ivanklee86 ivanklee86 merged commit 6c6bd97 into main Nov 14, 2025
10 checks passed
@ivanklee86 ivanklee86 deleted the update_project branch November 14, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants