Skip to content

Conversation

jekuaitk
Copy link
Contributor

@jekuaitk jekuaitk commented Jul 4, 2025

https://leantime.itkdev.dk/#/tickets/showTicket/4917

  • Updates docker compose setup
    • Adds missing frontend network to phpfpm in docker-compose.override.yml
    • Moves NGINX_MAX_BODY_SIZE adjustments to docker-compose.server.override.yml
    • Removes custom MEMCACHED_CACHE_SIZE from docker-compose.server.yml. It is already set to 128 in docker-compose.server.override.yml
  • Normalizes composer.json

@jekuaitk jekuaitk force-pushed the feature/update-docker-setup branch from abf0587 to 297e8e2 Compare July 4, 2025 12:36
@jekuaitk jekuaitk force-pushed the feature/update-docker-setup branch from 297e8e2 to 815999b Compare July 4, 2025 12:45
@jekuaitk jekuaitk requested a review from rimi-itk July 7, 2025 08:39
- app
environment:
- MEMCACHED_CACHE_SIZE=128
- MEMCACHED_CACHE_SIZE=64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're effectively decreasing MEMCACHED_CACHE_SIZE from 128 to 64 (by not setting it in docker-compose.server.override.yml). Is this on purpose?

Hint: You can use docker compose config to see the final config(uration) used by compose.

Copy link
Contributor Author

@jekuaitk jekuaitk Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already set. I should have mentioned this in the PR description. It is now!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry … I missed that …

@jekuaitk jekuaitk requested a review from rimi-itk July 7, 2025 11:44
@jekuaitk jekuaitk self-assigned this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants