Queued emails: Handle non-submission saving webforms and cleanup #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekuaitk
force-pushed
the
hotfix/queued-email-fixes
branch
from
37b46cb to
dab8451
Compare
rimi-itk
requested changes
May 7, 2025
web/modules/custom/os2forms_queued_email/src/Plugin/AdvancedQueue/JobType/QueuedEmail.php
Outdated
Show resolved
Hide resolved
web/modules/custom/os2forms_queued_email/src/Plugin/AdvancedQueue/JobType/QueuedEmail.php
Show resolved
Hide resolved
web/modules/custom/os2forms_queued_email/src/Plugin/AdvancedQueue/JobType/QueuedEmail.php
Outdated
Show resolved
Hide resolved
|
|
||
| // Remove OS2Forms attachments. | ||
| foreach ($os2formsAttachmentFilenames as $os2formsAttachmentFilename) { | ||
| unlink($os2formsAttachmentFilename); | ||
| } | ||
|
|
||
| $msg = sprintf('Email, %s, sent to %s. Webform id: %s.', $message['subject'], $message['to'], $submission->getWebform()->id()); | ||
| $msg = sprintf('Email, %s, sent to %s. Webform id: %s.', $payload['subject'] ?? NULL, $payload['to'] ?? NULL, $payload['webformId'] ?? NULL); |
There was a problem hiding this comment.
It may be worth moving this code before the file deletion to make sure that you only delete files if the job is succesful.
There was a problem hiding this comment.
With our current knowledge we assume that it is exactly these two lines that cause the sporadic issue, i.e. the 'stuckness' in the processing state and subsequent re-processings. Moving this above deletion would result in subsequent job processes also sending emails.
Currently we have:
- Sporadic false-positive failed jobs, i.e. the mail is sent.
If we move the code we would have:
- Sporadic multiple emails sent
I'm not sure which is better.
web/modules/custom/os2forms_queued_email/src/Plugin/AdvancedQueue/JobType/QueuedEmail.php
Outdated
Show resolved
Hide resolved
rimi-itk
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/tickets/showKanban#/tickets/showTicket/4308