4240: Added handler and element usage overview module #418
+409
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
reviewed
May 12, 2025
Comment on lines
25
to
26
| readonly private WebformElementManagerInterface $webformElementManager, | ||
| readonly private WebformEntityStorageInterface $webformEntityStorage, |
There was a problem hiding this comment.
I think
Suggested change
| readonly private WebformElementManagerInterface $webformElementManager, | |
| readonly private WebformEntityStorageInterface $webformEntityStorage, | |
| private readonly WebformElementManagerInterface $webformElementManager, | |
| private readonly WebformEntityStorageInterface $webformEntityStorage, |
reads nicer …
| * @phpstan-return array<string, mixed> | ||
| */ | ||
| public function buildForm(array $form, FormStateInterface $form_state) { | ||
| $form_state->setMethod('GET'); |
There was a problem hiding this comment.
Suggested change
| $form_state->setMethod('GET'); | |
| $form_state->setMethod(Request::METHOD_GET); |
Comment on lines
55
to
57
| $form['#cache'] = [ | ||
| 'max-age' => 0, | ||
| ]; |
There was a problem hiding this comment.
I suppose this form is only shown to authenticated users, and that this therefork works (cf. https://www.drupal.org/docs/drupal-apis/cache-api/cache-max-age#s-limitations-of-max-age). But it may be better to use no_cache (https://www.drupal.org/docs/drupal-apis/routing-system/structure-of-routes) in ….routing.yml to disable caching.
There was a problem hiding this comment.
Switched to no_cache.
Comment on lines
26
to
27
| readonly private WebformHandlerManagerInterface $webformHandlerManager, | ||
| readonly private WebformEntityStorageInterface $webformEntityStorage, |
There was a problem hiding this comment.
Suggested change
| readonly private WebformHandlerManagerInterface $webformHandlerManager, | |
| readonly private WebformEntityStorageInterface $webformEntityStorage, | |
| private readonly WebformHandlerManagerInterface $webformHandlerManager, | |
| private readonly WebformEntityStorageInterface $webformEntityStorage, |
Comment on lines
55
to
58
| $form_state->setMethod('GET'); | ||
| $form['#cache'] = [ | ||
| 'max-age' => 0, | ||
| ]; |
There was a problem hiding this comment.
See comment on caching elsewhere …
There was a problem hiding this comment.
Switched to no_cache.
rimi-itk
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/4240