osx support #5154
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ build:remote --remote_timeout=7200 | |
| # ======================================== | ||
|
|
||
| # Enable libc++ and C++20 by default. | ||
| build:linux --config=libc++20 | ||
|
|
||
| # Need for CI image to pickup docker-credential-gcloud, PATH is fixed in rbe-toolchain-* configs. | ||
| build:remote-ci --action_env=PATH=/usr/local/google-cloud-sdk/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/llvm/bin | ||
|
|
@@ -25,7 +25,8 @@ build --define path_normalization_by_default=true | |
|
|
||
| # Heap profiler is supported only with gperf tcmalloc, not google tcmalloc. | ||
| # See: https://github.com/istio/istio/issues/28233 | ||
| build:linux --define tcmalloc=gperftools | ||
| build:macos --define tcmalloc=disabled | ||
|
There was a problem hiding this comment. Same - why disable gperftools? There was a problem hiding this comment. always fails with following error: There was a problem hiding this comment. ok, it's fine but you won't get heap profile and some tools. what does tcmalloc disabled mean? what malloc is it using? There was a problem hiding this comment. envoy has same line, this's a known limitation. https://github.com/envoyproxy/envoy/blob/05457bb047b87f4cc1a25635400ddcaa7fccc923/.bazelrc#L138 I won't encourage anyone use proxy on macos for production, all these line make that easier to develop on macos. There was a problem hiding this comment. I don't recall, does There was a problem hiding this comment. if not, there must be huge problem. |
||
|
|
||
| # Build with embedded V8-based WebAssembly runtime. | ||
| build --define wasm=v8 | ||
|
|
@@ -67,3 +68,9 @@ build:clang-asan-ci --linkopt=-l:libclang_rt.ubsan_standalone_cxx.a | |
| build:clang-tsan-ci --config=clang-tsan | ||
| build:clang-tsan-ci --linkopt=-L/opt/libcxx_tsan/lib | ||
| build:clang-tsan-ci --linkopt=-Wl,-rpath,/opt/libcxx_tsan/lib | ||
|
|
||
| # get from https://github.com/Homebrew/homebrew-core/blob/master/Formula/e/envoy.rb | ||
| build:macos --cxxopt=-Wno-range-loop-analysis | ||
| build:macos --host_cxxopt=-Wno-range-loop-analysis | ||
| build:macos --cxxopt=-Wno-deprecated-declarations | ||
| build:macos --host_cxxopt=-Wno-deprecated-declarations | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why disable on macos? we have c++20 code already I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should use clang's lld on macos? what linker are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default one setting xcode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problems with allowing macos development. Just want to make sure we're not breaking release on linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do my best to make it won't happen, and there's a long time before next release, so I think it's pretty safe.