Skip to content

update sourceLabels and sourceNamespace docs #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

craigbox
Copy link
Contributor

@craigbox craigbox commented Jun 9, 2025

Closes #3258.

Happy to take guidance on better language; it felt best as a clarifying note to me.

@craigbox craigbox requested a review from a team as a code owner June 9, 2025 00:23
@istio-policy-bot
Copy link

😊 Welcome @craigbox! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2025
@craigbox craigbox added the release-notes-none Indicates a PR that does not require release notes. label Jun 9, 2025
@istio-testing istio-testing merged commit 2d8537b into istio:master Jun 9, 2025
5 checks passed
@craigbox craigbox added the cherrypick/release-1.26 Set this label on a PR to auto-merge it to release-1.26 branch label Jun 9, 2025
@craigbox craigbox deleted the sourceLabels branch June 9, 2025 22:56
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #3519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.26 Set this label on a PR to auto-merge it to release-1.26 branch release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve API documentation to explain sourceLabels and sourceNamespaces are selectors, not filters
5 participants