[WIP] Port to Qualtran v0.6 #57
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mpharrigan, this is extremely helpful! We'll figure out how to get this copied over and tested on our side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not complete, but here are some of the straightforward changes to support Qualtran v0.6. Feel free to take these changes and finish the job; or I will return to this at a later date. Alternatively, I could factor out the changes that make the code work with both Qualtran v0.4 and v0.6 to do this in a more incremental fashion.
This PR goes along with quantumlib/Qualtran#1655, which adds some shims directly to Qualtran. I can patch this in and release as v0.6.1 when we're closer