[3.3] Add TrendPerFilter option to AF After HFR Increase Trigger #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isbeorn
changed the title
isbeorn
reviewed
Oct 20, 2025
| - Fix issue where saving sequences after multi-file load overwrote only one XML | ||
| - **Time source failure reasons** | ||
| - When a time source fails to provide a value - e.g. that there is no astronomical twilight today - the validation will also include the reason for the failure. This will help to understand why a time source is not providing a value. | ||
| - **Autofocus after HFR Increase Trigger** |
There was a problem hiding this comment.
this should be moved to the 3.3 section
There was a problem hiding this comment.
please revert the whitespace changes
| } | ||
|
|
||
| if (fwInfo != null && fwInfo.Connected && fwInfo.SelectedFilter != null) { | ||
| if (fwInfo != null && fwInfo.Connected && fwInfo.SelectedFilter != null && TrendPerFilter == true) { |
There was a problem hiding this comment.
(TrendPerFilter && fwInfo != null && fwInfo.Connected && fwInfo.SelectedFilter != null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Purpose
adds a HFR trend per filter checkbox to the AF After HFR Increase Trigger. When enabled (default) HFR trend per filter is evaluated like in the original behaviour. When disabled, the HFR trend is evaluated across all filters combined.
This can help to trigger autofocus runs earlier, particular when imaging with frequent filter changes and a temperature sensitive optics on a quickly changing ambient temperature. Useful for example when imaging in L-R-G-B loops.
🧪 How Was It Tested?
Functionality been tested with my setup. In addition Unit tests been made.
✅ PR Checklist
Changelog.mdupdated (if applicable)🔗 Related Issues
📸 Screenshots
📝 Additional Notes