Skip to content

i965/drv: Move to per-gen HW format queries #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 31, 2025
Merged

Conversation

irql-notlessorequal
Copy link
Owner

@irql-notlessorequal irql-notlessorequal commented Mar 17, 2025

This has the benefit of being much tider and letting me clean up some questionable handling from Intel.

The disadvantage of this is that it duplicates a bunch of code, oh well.

Draft for the moment while I verify other platforms available to me:

  • SKL/KBL
  • BDW
  • CHV
  • HSW
  • SNB

GO AWAY VSCODE I BEG YOU
Will be used to provide easier per-platform formats caps.
HSW has the same formats exposed, so we can just reuse that.
Everything past Broadwell/CHV uses the same mega function.

Next commit will hook everything up.
This lets us have a much tidier layout in `i965_QuerySurfaceAttributes` while keeping everything much neater for each hardware generation.
We should probably be less assert() happy.
Instead make more use of `i965_log_debug`
We probably need to let `VAEntrypointVideoProc` through.

Plus import changes from 5cc0dc0
@irql-notlessorequal irql-notlessorequal modified the milestones: 2.4.4, 2.4.5 Mar 17, 2025
@irql-notlessorequal irql-notlessorequal modified the milestones: 2.4.5, 2.4.6 Mar 29, 2025
@irql-notlessorequal irql-notlessorequal modified the milestones: 2.4.6, 2.4.5 Apr 7, 2025
@irql-notlessorequal irql-notlessorequal marked this pull request as ready for review April 7, 2025 08:20
We can take advantage of the FALLTHROUGH macro that I've hooked up and just change the order of things.

Also updates the comment.
Updates the comment and pulls in one of X patches needed for G45/CTG H264 support.
We should _not_ expose VPP formats in the encoding context.
No actual change in functionality.
No actual change in functionality.
@irql-notlessorequal irql-notlessorequal self-assigned this May 10, 2025
@irql-notlessorequal irql-notlessorequal merged commit 3fa8045 into master May 31, 2025
@irql-notlessorequal irql-notlessorequal deleted the vpp-per-gen branch May 31, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant