i965/drv: Move to per-gen HW format queries #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GO AWAY VSCODE I BEG YOU
Will be used to provide easier per-platform formats caps.
HSW has the same formats exposed, so we can just reuse that.
Everything past Broadwell/CHV uses the same mega function. Next commit will hook everything up.
This lets us have a much tidier layout in `i965_QuerySurfaceAttributes` while keeping everything much neater for each hardware generation.
We should probably be less assert() happy. Instead make more use of `i965_log_debug`
We probably need to let `VAEntrypointVideoProc` through. Plus import changes from 5cc0dc0
I love pointers.
Closed
We can take advantage of the FALLTHROUGH macro that I've hooked up and just change the order of things. Also updates the comment.
Not needed, not supported.
Updates the comment and pulls in one of X patches needed for G45/CTG H264 support.
We should _not_ expose VPP formats in the encoding context.
No actual change in functionality.
No actual change in functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the benefit of being much tider and letting me clean up some questionable handling from Intel.
The disadvantage of this is that it duplicates a bunch of code, oh well.
Draft for the moment while I verify other platforms available to me: