Skip to content

Implement VolumeSnapshot IRI methods in volume poollet & broker #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2025
Merged

Implement VolumeSnapshot IRI methods in volume poollet & broker #1388

merged 3 commits into from
Oct 29, 2025

Conversation

@sujeet01
Copy link
Contributor

@sujeet01 sujeet01 commented Sep 23, 2025 •
edited
Loading

Proposed Changes

  • Volume Snapshot Controller: Implemented in volumepoollet for managing the full lifecycle of VolumeSnapshots.
  • Volume Broker IRI Methods: Implemented CreateVolumeSnapshot, DeleteVolumeSnapshot, and ListVolumeSnapshots with proper gRPC status handling.
  • VolumeSnapshotRef Field Indexer: Added field indexing in the volume controller for faster lookups when volumes reference snapshots.
  • Volume Restoration Flow: Added support for creating volumes from snapshots with correct data source handling.
  • Encryption Inheritance: Added encryption inheritance logic for volumes created from snapshots of encrypted volumes.
  • Error Handling: Enhanced error handling for missing encryption secrets, source volumes, and snapshots with proper gRPC status codes
  • Downward API Support: Added downward API labels support for VolumeSnapshot resource.
  • ImageDataSource Support: Added ImageDataSource handling with backward compatibility for soon-to-be-deprecated spec.image field.
  • Test Coverage: Added comprehensive test cases for VolumeSnapshot lifecycle, restoration flow, and encryption scenarios.

Fixes #1344 #1345

@sujeet01 sujeet01 self-assigned this Sep 23, 2025
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/feat/volumesnapshot-iri-implementation branch 3 times, most recently from 5402672 to 401cbc4 Compare September 25, 2025 11:48
@sujeet01 sujeet01 marked this pull request as ready for review September 26, 2025 07:18
@sujeet01 sujeet01 requested a review from a team as a code owner September 26, 2025 07:18
@sujeet01 sujeet01 marked this pull request as draft September 26, 2025 07:56
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/feat/volumesnapshot-iri-implementation branch 7 times, most recently from f4948c6 to 5e02238 Compare October 1, 2025 16:48
@sujeet01 sujeet01 marked this pull request as ready for review October 1, 2025 16:52
@lukasfrank lukasfrank self-requested a review October 6, 2025 07:39
kasabe28
kasabe28 reviewed Oct 8, 2025
View reviewed changes
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/feat/volumesnapshot-iri-implementation branch 4 times, most recently from 6447248 to c7735d4 Compare October 10, 2025 07:07
kasabe28
kasabe28 approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@kasabe28 kasabe28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/feat/volumesnapshot-iri-implementation branch from c7735d4 to 48eb391 Compare October 13, 2025 06:53
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Oct 14, 2025
@hardikdr hardikdr added this to Roadmap Oct 14, 2025
@lukasfrank lukasfrank requested a review from afritzler October 15, 2025 08:08
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/feat/volumesnapshot-iri-implementation branch 2 times, most recently from b627cb3 to df70ce4 Compare October 23, 2025 07:23
afritzler
afritzler requested changes Oct 23, 2025
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sujeet01 for the PR. Just some minor findings from my side. Apart from that the PR looks good!

@sujeet01 sujeet01 requested a review from afritzler October 24, 2025 10:03
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/feat/volumesnapshot-iri-implementation branch from ab4c75d to f8a1616 Compare October 28, 2025 04:08
@sujeet01 sujeet01 requested a review from lukasfrank October 28, 2025 04:48
@lukasfrank lukasfrank merged commit 4cc5e6f into ironcore-dev:main Oct 29, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

@kasabe28 kasabe28 kasabe28 approved these changes

@afritzler afritzler Awaiting requested review from afritzler

Assignees

@sujeet01 sujeet01

Labels

area/iaas Issues related to IronCore IaaS development. size/XXL

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance volumepoollet with snapshot support

5 participants

@sujeet01 @afritzler @lukasfrank @kasabe28 @hardikdr