Skip to content

Add hostname field to NetworkInterface #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add hostname field to NetworkInterface #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/core/v1alpha1/networkinterface_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"k8s.io/apimachinery/pkg/types"
)

// NetworkInterfaceSpec defines the desired state of NetworkInterface.
type NetworkInterfaceSpec struct {
// NodeRef is the node the network interface is hosted on.
NodeRef corev1.LocalObjectReference `json:"nodeRef"`
Expand All @@ -27,6 +28,9 @@ type NetworkInterfaceSpec struct {
// Can only be set if there is no matching IP family in PublicIPs.
NATs []NetworkInterfaceNAT `json:"natGateways,omitempty"`

// Hostname is the hostname which should be announced by the network interface.
Hostname string `json:"hostname,omitempty"`

// PublicIPs are the public IPs the network interface should have.
// +optional
// +patchMergeKey=name
Expand Down
9 changes: 9 additions & 0 deletions client-go/applyconfigurations/core/v1alpha1/networkinterfacespec.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions client-go/applyconfigurations/internal/internal.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion client-go/openapi/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions docs/api-reference/core.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,6 +1331,17 @@ Can only be set if there is no matching IP family in PublicIPs.</p>
</tr>
<tr>
<td>
<code>hostname</code><br/>
<em>
string
</em>
</td>
<td>
<p>Hostname is the hostname which should be announced by the network interface.</p>
</td>
</tr>
<tr>
<td>
<code>publicIPs</code><br/>
<em>
<a href="#core.apinet.ironcore.dev/v1alpha1.NetworkInterfacePublicIP">
Expand Down Expand Up @@ -3525,6 +3536,7 @@ github.com/ironcore-dev/ironcore-net/apimachinery/api/net.IP
(<em>Appears on:</em><a href="#core.apinet.ironcore.dev/v1alpha1.NetworkInterface">NetworkInterface</a>)
</p>
<div>
<p>NetworkInterfaceSpec defines the desired state of NetworkInterface.</p>
</div>
<table>
<thead>
Expand Down Expand Up @@ -3602,6 +3614,17 @@ Can only be set if there is no matching IP family in PublicIPs.</p>
</tr>
<tr>
<td>
<code>hostname</code><br/>
<em>
string
</em>
</td>
<td>
<p>Hostname is the hostname which should be announced by the network interface.</p>
</td>
</tr>
<tr>
<td>
<code>publicIPs</code><br/>
<em>
<a href="#core.apinet.ironcore.dev/v1alpha1.NetworkInterfacePublicIP">
Expand Down
Loading
Loading