Integrate SPRTA of CMAPLE into IQ-TREE #414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bqminh
reviewed
Feb 18, 2025
bqminh
reviewed
Mar 3, 2025
There was a problem hiding this comment.
change --zero-branch-supp to --sprta-zero-branch or something simpler
change --out-alter-spr to --sprta-other-places
change .nexus to .nex
make sure that the bracket notations in nexus file follow other features in IQ-TREE such as concordance factor.
remove all help usages in usage() function, you only need to keep them in usage_iqtree
|
Am I right that this is now merged into iqtree3 instead? |
|
Yes, Minh. These changes (including your suggestions above) were merged
into iqtree3.
…On Tue, 15 Apr 2025 at 6:45 pm, Bui Quang Minh ***@***.***> wrote:
Am I right that this is now merged into iqtree3 instead?
—
Reply to this email directly, view it on GitHub
<#414 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZPMLE5T3ZL23EKZKG3UO32ZTBKPAVCNFSM6AAAAABXBCDI7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBUGI4TKMRZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*bqminh* left a comment (iqtree/iqtree2#414)
<#414 (comment)>
Am I right that this is now merged into iqtree3 instead?
—
Reply to this email directly, view it on GitHub
<#414 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZPMLE5T3ZL23EKZKG3UO32ZTBKPAVCNFSM6AAAAABXBCDI7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBUGI4TKMRZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
ok then I close this pull request without merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate SPRTA of CMAPLE into IQ-TREE