Fitting Module Improvements (Documentation mostly) #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #155 +/- ##
==========================================
+ Coverage 91.87% 91.88% +0.01%
==========================================
Files 62 61 -1
Lines 6016 5988 -28
Branches 388 388
==========================================
- Hits 5527 5502 -25
+ Misses 407 404 -3
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ) | ||
|
|
||
| if np.isnan(error_i): | ||
| if np.isnan(error_i) or np.isinf(error_i): |
There was a problem hiding this comment.
Added the:
or np.isinf(error_i)To make the PT and LL specifications usable. Later, we can change that behaviour.
|
|
||
| dt = np.empty(1, order="F") if dt else None | ||
| dt2 = np.empty(1, order="F") if dt2 else None | ||
| dt = np.array(0, dtype=np.float64) if dt else None |
There was a problem hiding this comment.
This change in scalar derivatives of thermoprops (dt, dt2, dp, dv) prevents the annoying numpy deprecation warning
fedebenelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes expected (add more if desired)
New objectives: