Simplify API surface area #228
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for aborted builds
baronfel
reviewed
Aug 3, 2025
| /// <param name="buildParameters">All of the settings which must be specified to start a build</param> | ||
| /// <param name="ct">CancellationToken to cancel build submissions.</param> | ||
| /// <returns>The BuildResult</returns> | ||
| member x.BuildAsync(buildRequest: BuildRequestData, ?buildParameters: BuildParameters, ?ct: CancellationToken) = |
There was a problem hiding this comment.
There's a recent PR against MSbuild to add this as a core capability: dotnet/msbuild#12270
It'll be a bit until it lands and then is usable, but maybe the implementation can serve as a reference in the meantime.
There was a problem hiding this comment.
These are pretty much the same. Notable difference is I'm converting BuildAbortedException to OperationCanceledException when cancellation did happen.
…or clarity and consistency
- Introduced `TestUtils` module to encapsulate common testing functions and utilities. - Updated `TestAssetProjInfo2` to include new expectations for graph and project results. - Refactored existing tests to utilize the new `TestUtils` functions for better readability and maintainability. - Replaced inline error handling and logging with structured approaches in tests. - Ensured all tests now conform to the new expectations for project options, graph results, and project results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.