Add formatting and Warnings as Errors #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This depends on #32, but I can't see how to do that in GitHub? |
tboby
changed the title
Contributor
Contributor
|
ok, now if you rebase and stuff this should look reasonble |
tboby
force-pushed
the
apply-formatting
branch
from
d1ea73b to
0d6c9ff
Compare
Contributor
Author
Done, and squashed further formatting |
baronfel
previously approved these changes
Oct 24, 2024
baronfel
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This reapplies the formatting and
WarningsAsErrorsfrom #24, and modifies the pipeline to fail on formatting failure.It doesn't include the dependabot addition.
WHY
<3 Fantomas