test(item-sliding): add test for side issue with CDN #30469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
christian-bromann
approved these changes
Jun 10, 2025
Comment on lines
59
to
61
| <link href="${baseUrl}/scripts/testing/styles.css" rel="stylesheet" /> | ||
| ${palette !== 'light' ? `<link href="${baseUrl}/css/palettes/${palette}.always.css" rel="stylesheet" />` : ''} | ||
| <script src="${baseUrl}/scripts/testing/scripts.js"></script> |
There was a problem hiding this comment.
Why not these as well?
There was a problem hiding this comment.
The testing scripts file is required for Playwright. Without it we would have to set all of the stuff for telling Playwright the app is loaded and determining the document direction, palette, etc: https://github.com/ionic-team/ionic-framework/blob/main/core/scripts/testing/scripts.js
I actually accidentally removed this at first and ran into an issue where none of the test after setContent was executed because window.testAppLoaded = true was never set.
ShaneK
approved these changes
Jun 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…alue (#29845) Issue number: resolves #29499 --------- ## What is the current behavior? Using the bundled version of Ionic results in an error `Uncaught (in promise) Error: "undefined" is not a valid value for [side]. Use "start" or "end" instead.` with `<ion-item-sliding>`. Reproduction 1: - https://stackblitz.com/edit/stackblitz-starters-mezoy6?file=index.html - Press the Add (`+`) button several times It is also reproducible in an Ionic Angular app when installed via npm. Reproduction 2: - https://stackblitz.com/edit/angular-exwgke?file=src%2Fapp%2Fexample.component.ts - Press the `Add Items` button several times ## What is the new behavior? Check for the side attribute to avoid `side` being `undefined`. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Dev build: `8.6.1-dev.11749562115.1e681558` Test PR: #30469 The tests must be merged separately, after this is released, in order to use the fix from the CDN. --------- Co-authored-by: Brandy Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for #29845
Must be merged after the fix in that PR is released. The test will fail while using the older version of the CDN.