docs(reorder): add new ionReorderStart, ionReorderMove, ionReorderEnd event playgrounds #4149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
Jun 13, 2025
| @@ -73,6 +73,29 @@ import UpdatingData from '@site/static/usage/v8/reorder/updating-data/index.md'; | |||
|
|
|||
| <UpdatingData /> | |||
|
|
|||
| ## Event Handling | |||
There was a problem hiding this comment.
I don't love these section headings, but I decided to be consistent with how Range documents its events. If we want to change this I can update both components.
brandyscarney
commented
Jun 13, 2025
|
|
||
| The `ionReorderEnd` event is emitted when the user completes the reorder gesture by removing their pointer from the screen. The event includes the `from` and `to` indices of the item, as well as the `complete` method that should be called to finalize the reorder operation. The `from` index will always be the position of the item when the gesture started, while the `to` index will be its final position. This event will fire even if no items have changed position, in which case the `from` and `to` indices will be the same. | ||
|
|
||
| import ReorderStartEndEvents from '@site/static/usage/v8/reorder/reorder-start-end-events/index.md'; |
There was a problem hiding this comment.
I didn't like how range prefixes ion- in the directory names but I can update this if we want consistency.
brandyscarney
requested review from
ShaneK and
thetaPC
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Using ionReorderStart and ionReorderEndandUsing ionReorderMove@deprecatedevents (this was previously not accounted for at all) and updates the styling for deprecated propsExample of the new styles (the deprecated property was added just to show the visual updates, I did not deprecate
disabled):Previews