Replace static return types with self in SheetsClient for improved mock testing #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR replaces all
static
return types withself
in theSheetsClient
class and related components to make mock testing of chained methods easier.Files Modified
src/Contracts/Factory.php
- Updated interface declarations fromstatic
toself
(10 methods)src/SheetsClient.php
- Changed method return types fromstatic
toself
(6 methods)src/Concerns/SheetsDrive.php
- Changed method return types fromstatic
toself
(1 method)src/Concerns/SheetsValues.php
- Changed method return types fromstatic
toself
(4 methods)src/Facades/Sheets.php
- Updated@method
annotations fromstatic static
tostatic self
(11 annotations)Methods Updated
setService()
,setAccessToken()
,spreadsheet()
,spreadsheetByTitle()
,sheet()
,sheetById()
,setDriveService()
,range()
,majorDimension()
,valueRenderOption()
,dateTimeRenderOption()
Why This Change?
The change from
static
toself
improves mock testing capabilities because:self
refers to the exact class where it's defined, making it more predictable for mockingstatic
uses late static binding which can be harder to mock in inheritance scenariosTesting
Example Usage (unchanged)
The functionality remains identical for end users, but developers writing tests can now mock chained method calls more reliably.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.