[uss_qualifier] constraints sync: verify secondary DSS instances are clean #1133
Conversation
Shastick
force-pushed
the
clean-secondaries-checks-4
branch
from
e57f855 to
6eae58d
Compare
Shastick
force-pushed
the
clean-secondaries-checks-4
branch
from
6eae58d to
8ba3890
Compare
Shastick
force-pushed
the
clean-secondaries-checks-4
branch
from
8ba3890 to
dd0fd46
Compare
| if cr.ovn is None: | ||
| check.record_failed( | ||
| summary=f"CR {cr_id} is missing OVN", | ||
| details="The CR retrieved from the DSS did not include an OVN, despite the CR being owned by uss_qualifier. The scenario cannot proceed.", |
There was a problem hiding this comment.
We shouldn't write "The scenario cannot proceed" here as the canonical location for that information is in the documentation (the stop sign unicode character) and we don't want redundant information that can drift out of sync.
Moreover, if the scenario truly cannot proceed if/when this check fails, shouldn't we throw some kind of ScenarioDidNotStop or similar exception following the check rather than continuing normally with the return statement?
There was a problem hiding this comment.
Correct: we should raise the special exception we recently introduced. Technically the cleanup step cannot continue if the ovn is none (we'd fail on the next step when accessing the ovn anyway) but the scenario cannot proceed if one of the DSSes is not in a clean state either.
I'll raise instead. (both here and below on line 303)
closes #810