Adding new processor class for artifactory

[isc-jlechtne]

This PR addresses #935

This is for creating a new generic resource processor to cover bundling an artifact with a package and deploying it to a final location on install.

Behavior on packaging:

• Always attempts to download the artifact.
• Artifact untarred and moved to a location under the module root

Behavior on activation:

• Check if artifact files exist under the module root. If they don't, download and move them there (as in packaging)
• With untarred files under module root, move them to their final deployed location. This location is specified by DeployDirectory or DevDirectory if defined and installed in dev mode.

[isc-dchui]

@isc-jlechtne Left a few comments/thoughts!

[isc-eneil]

Left my first round of comments @isc-jlechtne. Looks pretty good to me!

[isc-eneil]

One more note @isc-jlechtne: this could use some integration tests (not sure how you'd obscure Arti credentials so may be a bit tricky)

[isc-kiyer]

@isc-jlechtne This is a good draft of migrating over stuff from AngularArtifact but its not yet generic for any IPM consumer (need to get out of the lens of just our use case). We can chat about it offline if you want but in its current state, this is not generally usable for pulling any arbitrary artifact from Artifactory.

[isc-dchui]

Just a few questions

[isc-kiyer]

@isc-jlechtne few comments up but general logic looks good!

[isc-eneil]

Took a look-- no comments beyond those that Keshav already provided regarding using environment variables over params. Looks good! @isc-jlechtne

[isc-kiyer]

@isc-jlechtne Looks good! Last few minor comments. We need some tests for this though so any thought as to how to add those?

[isc-jlechtne]

@isc-jlechtne Looks good! Last few minor comments. We need some tests for this though so any thought as to how to add those?

@isc-kiyer I talked with @isc-eneil yesterday and she volunteered to take on writing the tests to better swarm on this. How to write the tests without exposing credentials required for the tests, however, is something both of us did not have an initial answer for.

[isc-dchui]

Looks good, just one more thing!

[isc-kiyer]

@isc-jlechtne few minor comments. Also, I think it would be good to work with @isc-dchui to figure out the tarball unpacking error when using FileBinaryTar since we should use one consistent approach for unpacking/packing tarballs

[isc-dchui]

Just a few small things

[isc-eneil]

@isc-jlechtne Approved assuming the very small nits are addressed.