add unregister wait_tensor #2019
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a call to unregister work when synchronizing a WorkXCCL instance, implementing proper cleanup for inflight collective operations when they complete.
- Adds conditional work unregistration in the synchronize() method based on a feature flag
- Uses unsafe_reclaim_from_nonowning to create an intrusive_ptr for the unregistration call
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zhangxiaoli73
approved these changes
Sep 8, 2025
|
@Chao1Han Please merge this PR after CI pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #2019, support allow_inflight_collective_as_graph unregister