Update to recommended shortcut API for kernel specific max work group size #1989
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the SYCL kernel work group size retrieval by replacing manual kernel bundle construction with the recommended sycl::ext::oneapi::get_kernel_info API. This change reduces code complexity and improves maintainability.
Key changes:
- Replaces 4-line manual kernel bundle creation and querying with a single direct API call
- Uses the oneAPI extension for more streamlined kernel information retrieval
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CuiYifeng
force-pushed
the
yifeng/shortcut_sycl_api
branch
from
0040fa0 to
9cd1bb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how the maximum work group size for a SYCL kernel is retrieved in the
syclMaxWorkGroupSizefunction. The manual construction and querying of a kernel bundle is replaced withsycl::ext::oneapi::get_kernel_infofor directly obtaining the work group size, simplifying the code and improving clarity.