-
Notifications
You must be signed in to change notification settings - Fork 795
[DevASAN] Move memory alloc info into DeviceInfo #20611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhaomaosu
wants to merge
5
commits into
intel:sycl
Choose a base branch
from
zhaomaosu:asan-indirect-access
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+89
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since CPU/GPU device both support USM indirect access, we need to poison shadow of whole allocated memory in the device instead of only one context.
zhaomaosu
commented
Nov 11, 2025
Contributor
|
I think this PR is causing UR hangs, please make sure it's fixed before running CI again, thanks. |
jinge90
approved these changes
Nov 13, 2025
pbalcer
approved these changes
Nov 14, 2025
Contributor
pbalcer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just two small comments.
unified-runtime/source/loader/layers/sanitizer/msan/msan_interceptor.hpp
Show resolved
Hide resolved
unified-runtime/source/loader/layers/sanitizer/msan/msan_interceptor.hpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CPU/GPU device both support USM indirect access, we need to poison shadow of whole allocated memory in the device instead of only one context.