[UR][SYCL] Replace urEnqueueKernelLaunch property list with pNext chain property structs #20596

ldorau · 2025-11-07T17:09:17Z

Replace urEnqueueKernelLaunch() property list with pNext chain property structures.
It resolves Jira URT-990

kswiecicki · 2025-11-12T13:13:01Z

unified-runtime/source/adapters/level_zero/v2/command_list_manager.cpp

+    return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
+  }
+
+  while (_launchPropList != nullptr) {


You can parse those properties using find_stype_node (like here https://github.com/intel/llvm/blob/sycl/unified-runtime/source/adapters/level_zero/usm.cpp#L1052).

I think it cannot be used in this place, since we are not looking for a specific type here. Is it right?

ldorau · 2025-11-13T09:30:26Z

Rebased

sycl/source/detail/scheduler/commands.cpp

steffenlarsen · 2025-11-13T10:58:22Z

unified-runtime/scripts/core/enqueue.yml

-      name: numPropsInLaunchPropList
-      desc: "[in] size of the launch prop list"
-    - type: const $x_kernel_launch_property_t*
+    - type: const $x_kernel_launch_ext_properties_t*


My understanding was that it was only experimental interfaces that were allowed to change arguments. Is that not the case?

steffenlarsen · 2025-11-13T12:54:02Z

Just for future reference, it would be preferable if you avoid doing force-pushes. It makes if more difficult to track what changes between reviews. Merges squash commits and uses the description and title of the PR, so it will still become a single commit in the end.

ldorau · 2025-11-13T13:04:35Z

The make generate step produces a wrong output in the Unified Runtime Pre Commit / Source Checks / source_checks (windows-2022) (pull_request) CI job - the code does not compile with the generated output source code.

unified-runtime/source/adapters/cuda/enqueue.cpp

steffenlarsen · 2025-11-13T13:12:39Z

The make generate step produces a wrong output in the Unified Runtime Pre Commit / Source Checks / source_checks (windows-2022) (pull_request) CI job - the code does not compile with the generated output source code.

That is interesting. It looks like it is related to #20610, but UR CI don't run for libclc, so I don't think we caught it as part of that. @jinge90 - Are the changes it suggest valid? It doesn't look valid to me.

steffenlarsen

SYCL RT, NativeCPU, CUDA and HIP changes LGTM!

sarnex · 2025-11-13T16:27:17Z

The make generate step produces a wrong output in the Unified Runtime Pre Commit / Source Checks / source_checks (windows-2022) (pull_request) CI job - the code does not compile with the generated output source code.

That is interesting. It looks like it is related to #20610, but UR CI don't run for libclc, so I don't think we caught it as part of that. @jinge90 - Are the changes it suggest valid? It doesn't look valid to me.

We can ignore it, the linked PR (not this one) caused some nonsense on Windows.

@ldorau Please rebase on top of HEAD and run CI again

ldorau · 2025-11-13T19:57:30Z

The make generate step produces a wrong output in the Unified Runtime Pre Commit / Source Checks / source_checks (windows-2022) (pull_request) CI job - the code does not compile with the generated output source code.

That is interesting. It looks like it is related to #20610, but UR CI don't run for libclc, so I don't think we caught it as part of that. @jinge90 - Are the changes it suggest valid? It doesn't look valid to me.

We can ignore it, the linked PR (not this one) caused some nonsense on Windows.

@ldorau Please rebase on top of HEAD and run CI again

Rebased.

nrspruit · 2025-11-13T20:24:44Z

FYI, the failures happening in https://github.com/intel/llvm/actions/runs/19344092070/job/55340836099?pr=20596 seem to be due to a race condition that has existed since the V1/V2 adapters for L0 were allowed to be "skipped". The adapters were not being properly torndown resulting in sporadic crashes. This fixes that problem #20642 .

To fix that issue you will need to merge my PR first.

nrspruit · 2025-11-13T20:44:58Z

FYI, the failures happening in https://github.com/intel/llvm/actions/runs/19344092070/job/55340836099?pr=20596 seem to be due to a race condition that has existed since the V1/V2 adapters for L0 were allowed to be "skipped". The adapters were not being properly torndown resulting in sporadic crashes. This fixes that problem #20642 .

To fix that issue you will need to merge my PR first.

nevermind, my fix does resolve an issue, but this sporadic UR only issue in V2 persists. I at least cannot reproduce the hang outside of the CI.

mmichel11

Command buffer changes LGTM

…ty structs Signed-off-by: Lukasz Dorau <[email protected]>

ldorau had a problem deploying to WindowsCILock November 7, 2025 17:09 — with GitHub Actions Error

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 5e31e12 to b0df01e Compare November 7, 2025 17:18

ldorau had a problem deploying to WindowsCILock November 7, 2025 17:19 — with GitHub Actions Failure

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from b0df01e to a000354 Compare November 7, 2025 20:47

ldorau had a problem deploying to WindowsCILock November 7, 2025 20:47 — with GitHub Actions Error

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from a000354 to 1ae0f9d Compare November 7, 2025 20:57

ldorau had a problem deploying to WindowsCILock November 7, 2025 20:58 — with GitHub Actions Failure

ldorau had a problem deploying to WindowsCILock November 7, 2025 21:31 — with GitHub Actions Failure

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 1ae0f9d to 01c7fc1 Compare November 12, 2025 09:59

ldorau temporarily deployed to WindowsCILock November 12, 2025 10:00 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock November 12, 2025 10:25 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock November 12, 2025 10:25 — with GitHub Actions Failure

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 01c7fc1 to 2a106f0 Compare November 12, 2025 11:16

ldorau had a problem deploying to WindowsCILock November 12, 2025 11:16 — with GitHub Actions Failure

ldorau temporarily deployed to WindowsCILock November 12, 2025 11:45 — with GitHub Actions Inactive

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 2a106f0 to 5f3a8b9 Compare November 12, 2025 12:16

ldorau had a problem deploying to WindowsCILock November 12, 2025 12:16 — with GitHub Actions Error

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 5f3a8b9 to 94998d8 Compare November 12, 2025 12:40

ldorau temporarily deployed to WindowsCILock November 12, 2025 12:41 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock November 12, 2025 13:11 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock November 12, 2025 13:11 — with GitHub Actions Failure

ldorau temporarily deployed to WindowsCILock November 12, 2025 13:11 — with GitHub Actions Inactive

kswiecicki reviewed Nov 12, 2025

View reviewed changes

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 94998d8 to 5dc229b Compare November 12, 2025 13:37

ldorau had a problem deploying to WindowsCILock November 12, 2025 13:37 — with GitHub Actions Error

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 5dc229b to d1589af Compare November 12, 2025 13:41

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 17fdcc7 to 889ed38 Compare November 13, 2025 09:58

ldorau had a problem deploying to WindowsCILock November 13, 2025 09:58 — with GitHub Actions Failure

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 889ed38 to 017d5f3 Compare November 13, 2025 10:08

ldorau had a problem deploying to WindowsCILock November 13, 2025 10:08 — with GitHub Actions Failure

ldorau had a problem deploying to WindowsCILock November 13, 2025 10:10 — with GitHub Actions Failure

ldorau had a problem deploying to WindowsCILock November 13, 2025 10:36 — with GitHub Actions Failure

steffenlarsen reviewed Nov 13, 2025

View reviewed changes

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 017d5f3 to a512bd9 Compare November 13, 2025 12:50

ldorau had a problem deploying to WindowsCILock November 13, 2025 12:50 — with GitHub Actions Failure

steffenlarsen reviewed Nov 13, 2025

View reviewed changes

unified-runtime/source/adapters/cuda/enqueue.cpp Show resolved Hide resolved

unified-runtime/source/adapters/cuda/enqueue.cpp Outdated Show resolved Hide resolved

ldorau had a problem deploying to WindowsCILock November 13, 2025 13:19 — with GitHub Actions Failure

ldorau requested a review from steffenlarsen November 13, 2025 13:19

steffenlarsen approved these changes Nov 13, 2025

View reviewed changes

ldorau had a problem deploying to WindowsCILock November 13, 2025 16:07 — with GitHub Actions Failure

ldorau force-pushed the Replace_urEnqueueKernelLaunch_property_list_with_pNext_chain_property_structs branch from 107a00b to 832ea04 Compare November 13, 2025 19:55

ldorau temporarily deployed to WindowsCILock November 13, 2025 19:56 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock November 13, 2025 20:25 — with GitHub Actions Inactive

mmichel11 approved these changes Nov 13, 2025

View reviewed changes

ldorau added 2 commits November 13, 2025 20:56

Replace urEnqueueKernelLaunch() property list with pNext chain proper…

a033a50

…ty structs Signed-off-by: Lukasz Dorau <[email protected]>

Fixes after review

832ea04

[UR][SYCL] Replace urEnqueueKernelLaunch property list with pNext chain property structs #20596

Are you sure you want to change the base?

[UR][SYCL] Replace urEnqueueKernelLaunch property list with pNext chain property structs #20596

Conversation

ldorau commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kswiecicki Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ldorau Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ldorau commented Nov 13, 2025

Uh oh!

Uh oh!

Uh oh!

steffenlarsen Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

ldorau Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

steffenlarsen commented Nov 13, 2025

Uh oh!

ldorau commented Nov 13, 2025

Uh oh!

Uh oh!

Uh oh!

steffenlarsen commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

sarnex commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldorau commented Nov 13, 2025

Uh oh!

nrspruit commented Nov 13, 2025

Uh oh!

nrspruit commented Nov 13, 2025

Uh oh!

mmichel11 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ldorau commented Nov 7, 2025 •

edited

Loading

steffenlarsen commented Nov 13, 2025 •

edited

Loading

sarnex commented Nov 13, 2025 •

edited

Loading