Skip to content

[DevSAN] Change DeviceType to specialization constant #19798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: sycl
Choose a base branch
from
Open

[DevSAN] Change DeviceType to specialization constant #19798

wants to merge 5 commits into from
+109 −40

Conversation

zhaomaosu
Copy link
Contributor

This will allow backend compiler to eliminte unnecessary code to reduce kernel code size.

@zhaomaosu
[DevSAN] Change DeviceType to specialization constant
71a5527 
This will allow backend compiler to eliminte unnecessary code to reduce
kernel code size.
@zhaomaosu zhaomaosu marked this pull request as ready for review August 14, 2025 06:48
@zhaomaosu zhaomaosu requested review from a team as code owners August 14, 2025 06:48
@zhaomaosu
Copy link
Contributor Author

Hi @steffenlarsen, I have another question. The pre-ci for testing ABI compatibility is failed due to this PR will indeed break ABI compatibility. However, the ABI compatibility is unimportant to device sanitizer since the user must re-build their code if they want to test their code with device sanitizer. Do you know if there is a way to disable a test under ABI compatibility testing mode?

@steffenlarsen
Copy link
Contributor

Hi @steffenlarsen, I have another question. The pre-ci for testing ABI compatibility is failed due to this PR will indeed break ABI compatibility. However, the ABI compatibility is unimportant to device sanitizer since the user must re-build their code if they want to test their code with device sanitizer. Do you know if there is a way to disable a test under ABI compatibility testing mode?

I believe it should be as simple as adding the tests at the top of devops/compat_ci_exclude.sycl-rel-6_3 with a comment stating why it is OK for it to break compatibility.

@aelovikov-intel
Copy link
Contributor

Hi @steffenlarsen, I have another question. The pre-ci for testing ABI compatibility is failed due to this PR will indeed break ABI compatibility. However, the ABI compatibility is unimportant to device sanitizer since the user must re-build their code if they want to test their code with device sanitizer. Do you know if there is a way to disable a test under ABI compatibility testing mode?

I'm not sure @xtian-github agrees with that: #19719 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZyne AllanZyne AllanZyne approved these changes

@pbalcer pbalcer pbalcer approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@Nuullll Nuullll Awaiting requested review from Nuullll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhaomaosu @steffenlarsen @aelovikov-intel @AllanZyne @pbalcer