[Benchmarks] Add chart annotations #19023
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
force-pushed
the
charts-annotations
branch
from
7b0d277 to
9dd752e
Compare
PatKamin
force-pushed
the
charts-annotations
branch
from
9dd752e to
556f734
Compare
|
Can you show a screenshot? |
Sure, here is an example with three annotations clicked, hence their labels are visible (active). The default view includes no labels being displayed. |
with information on each version change of important dependecies, like Compute Runtime and benchmarks repos
pbalcer
reviewed
Jun 18, 2025
| name: "Compute Benchmarks", | ||
| url: "https://github.com/intel/compute-benchmarks.git", | ||
| color: { | ||
| border: 'rgba(220, 53, 69, 0.8)', |
There was a problem hiding this comment.
I know it's a minor thing, but maybe we should pick colors that aren't similar to what we use for data series? someone might misinterpret the annotation as relating to just one series.
(i'm not sure it's going to be possible).
Comment on lines
+48
to
+49
| name: "Compute Benchmarks", | ||
| url: "https://github.com/intel/compute-benchmarks.git", |
There was a problem hiding this comment.
aren't these stored in group metadata? we should ideally create this list automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with information on each version change of important dependecies, like Compute Runtime and benchmarks repos.
To see a label with a new version of Compute Runtime or a benchmark, click the annotation.