Skip to content

[CI] Remove workarounds #19017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[CI] Remove workarounds #19017

wants to merge 2 commits into from

Conversation

KornevNikita
Copy link
Contributor

devops_ref and cts_exclude_ref were used as workaronds to launch sycl-rel-nightly with the sycl-rel branch using the regular sycl branch. Now we run sycl-rel-nightly using the sycl-rel branch, so there is no need to keep these workarounds.

@KornevNikita KornevNikita requested a review from a team as a code owner June 17, 2025 10:23
@KornevNikita
Copy link
Contributor Author

Test run - https://github.com/intel/llvm/actions/runs/15685104960
All failures are known.

@KornevNikita
Copy link
Contributor Author

BTW I guess this arg may also be eliminated (or at least changed to required: False):

repo_ref: ${{ github.sha }}

Now it's expected to always be github.sha, so we probably can painlessly drop it. @intel/dpcpp-devops-reviewers should we?

@aelovikov-intel
Copy link
Contributor

BTW I guess this arg may also be eliminated (or at least changed to required: False):

repo_ref: ${{ github.sha }}

Now it's expected to always be github.sha, so we probably can painlessly drop it. @intel/dpcpp-devops-reviewers should we?

Was it like that before the release CI changes, or did you have to add it? If you added, then feel free to drop.

@KornevNikita
Copy link
Contributor Author

BTW I guess this arg may also be eliminated (or at least changed to required: False):

repo_ref: ${{ github.sha }}

Now it's expected to always be github.sha, so we probably can painlessly drop it. @intel/dpcpp-devops-reviewers should we?

Was it like that before the release CI changes, or did you have to add it? If you added, then feel free to drop.

Nope, looks like it was there before my change, I just renamed this input. So this is ready then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants