-
Notifications
You must be signed in to change notification settings - Fork 778
[SYCL] Fix 2D slicepitch info #18960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
Make slicepitch image size and num slices 1 for a 2D image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we have a test for this? |
I could potentially make a unittest that checks whether a valid slice pitch is passed to the backend. The slice pitch is not exposed to the user for 2D images so the test would need to look at a backend |
unittest works for me! Thanks! |
Make sure the SYCL runtime is passing correct values to UR layer.
I've added a test in the E2E tests. There weren't any |
Don't run on L0 and remove the std::cout at the end.
Make
slicePitch
equal to image size andnumSlices
1 for a 2D image.This was incorrect but wasn't failing as many backends ignore
Pitch[1]
for a 2D image.