Skip to content

[SYCL] Fix 2D slicepitch info #18960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Jun 12, 2025

Make slicePitch equal to image size and numSlices 1 for a 2D image.

This was incorrect but wasn't failing as many backends ignore Pitch[1] for a 2D image.

Make slicepitch image size and num slices 1 for a 2D image.
@hdelan hdelan requested a review from a team as a code owner June 12, 2025 15:49
@hdelan hdelan requested a review from maarquitos14 June 12, 2025 15:49
@hdelan hdelan temporarily deployed to WindowsCILock June 12, 2025 15:50 — with GitHub Actions Inactive
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maarquitos14
Copy link
Contributor

Can we have a test for this?

@hdelan hdelan temporarily deployed to WindowsCILock June 12, 2025 16:45 — with GitHub Actions Inactive
@hdelan hdelan temporarily deployed to WindowsCILock June 12, 2025 16:45 — with GitHub Actions Inactive
@hdelan
Copy link
Contributor Author

hdelan commented Jun 12, 2025

I could potentially make a unittest that checks whether a valid slice pitch is passed to the backend. The slice pitch is not exposed to the user for 2D images so the test would need to look at a backend SYCL_UR_TRACE.

@maarquitos14
Copy link
Contributor

I could potentially make a unittest that checks whether a valid slice pitch is passed to the backend. The slice pitch is not exposed to the user for 2D images so the test would need to look at a backend SYCL_UR_TRACE.

unittest works for me! Thanks!

Make sure the SYCL runtime is passing correct values to
UR layer.
@hdelan hdelan temporarily deployed to WindowsCILock June 17, 2025 16:42 — with GitHub Actions Inactive
@hdelan
Copy link
Contributor Author

hdelan commented Jun 17, 2025

I've added a test in the E2E tests. There weren't any unittests using SYCL_UR_TRACE as this test does, and only a handful of tests in test so I though test-e2e was the most natural place for these.

Don't run on L0 and remove the std::cout at the end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants