openapijson2schema/command.py: throw error instead of proceeding #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we can't find either 'swagger' or 'openapi' keys, previously we'd get an UnboundLocalError because of an undefined variable. Even if we fixed that, it is probably bad to continue with command flow when the behavior is not well defined. Instead throw an error to exit execution immediately. Fixes instrumenta#16.
kevinburkesegment
force-pushed
the
missing-key
branch
from
a0af656 to
4957b06
Compare
|
I'm collecting fixes in https://github.com/larsks/openapi2jsonschema. I've merged this patch into that repository. |
hectorm
added a commit
to hectorm/openapi2jsonschema
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can't find either 'swagger' or 'openapi' keys, previously we'd
get an UnboundLocalError because of an undefined variable. Even if we
fixed that, it is probably bad to continue with command flow when the
behavior is not well defined. Instead throw an error to exit execution
immediately.
Fixes #16.