Skip to content

[skip vbump] Release candidate v0.5.11 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 9, 2025
Merged

Conversation

Melkiades
Copy link
Contributor

Achieves release #344

@Melkiades Melkiades added sme Tracks changes for the sme board release Pertaining to a software release labels Apr 7, 2025
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Unit Tests Summary

  1 files    8 suites   15s ⏱️
 55 tests  55 ✅ 0 💤 0 ❌
416 runs  416 ✅ 0 💤 0 ❌

Results for commit a5177c3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       262       5  98.09%   110, 216, 255, 523, 531
R/generics.R           125      12  90.40%   148, 286-290, 492, 504, 535, 565, 673, 686, 707-714
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        692      41  94.08%   132, 393, 513-514, 606, 616-619, 637, 668, 758-759, 773-778, 808-811, 871-872, 961-962, 989, 1017, 1069, 1231, 1267, 1270-1274, 1324, 1372, 1375, 1379
R/mpf_exporters.R      287      28  90.24%   2, 102-112, 157, 193, 238, 241, 246, 426-432, 436, 439, 443, 491, 570
R/page_size.R           42       1  97.62%   219
R/pagination.R         764      52  93.19%   327-330, 435-450, 540, 595, 600, 641, 679-690, 766, 878-879, 901-910, 1049, 1100-1101, 1254, 1291-1295, 1312, 1319, 1402, 1542-1543, 1559-1560, 1574-1575
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 660-663, 669-673, 676-679, 686-691, 774-775, 915-916, 981-988, 1038-1042, 1111, 1164, 1183-1187, 1198, 1216, 1233, 1248, 1346, 1389, 1434, 1520, 1559, 1613, 1620
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 3030     218  92.81%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a5177c3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Melkiades and others added 2 commits April 7, 2025 17:17
Co-authored-by: Joe Zhu <[email protected]>
Signed-off-by: Davide Garolini <[email protected]>
@shajoezhu
Copy link
Contributor

Dear package maintainer,

this notification has been generated automatically.
Your package formatters_0.5.11.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at:
https://win-builder.r-project.org/SJrFPJZMN1VL
The files will be removed after roughly 72 hours.
Installation time in seconds: 11
Check time in seconds: 149
Status: OK
R version 4.4.3 (2025-02-28 ucrt)

All the best,
Uwe Ligges
(CRAN maintainer of binary packages for Windows)

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Melkiades , thanks for the changes, the windows built check was successful.

can you please update the following orcids in the description file

Davide 0000-0002-1445-1369
Emily 0009-0000-8738-5561
Abinaya 0009-0005-2083-1105

and recompile the documentation

can you also check if there is any breaking changes (use R CMD check) for
https://cran.r-project.org/web/packages/mcradds/index.html and https://cran.r-project.org/web/packages/tables/index.html, if any breaking changes, we will either fix them, make suggestions, and let the downstream author know, I am checking their status on main branches at https://github.com/insightsengineering/formatters/actions/runs/14323141411/job/40143736057

@Melkiades
Copy link
Contributor Author

hi @Melkiades , thanks for the changes, the windows built check was successful.

can you please update the following orcids in the description file

Davide 0000-0002-1445-1369 Emily 0009-0000-8738-5561 Abinaya 0009-0005-2083-1105

and recompile the documentation

can you also check if there is any breaking changes (use R CMD check) for https://cran.r-project.org/web/packages/mcradds/index.html and https://cran.r-project.org/web/packages/tables/index.html, if any breaking changes, we will either fix them, make suggestions, and let the downstream author know, I am checking their status on main branches at https://github.com/insightsengineering/formatters/actions/runs/14323141411/job/40143736057

Done! Ready for submission!

@Melkiades
Copy link
Contributor Author

@shajoezhu

The maintainer of this package has been sent an email to confirm the submission. After their confirmation the package will be passed to CRAN for review.

Please note that the submission is not completed until it is confirmed by the maintainer (via the link in the e-mail).

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @Melkiades

@Melkiades Melkiades merged commit 1d34f8a into main Apr 9, 2025
42 of 43 checks passed
@Melkiades Melkiades deleted the release-candidate-v0.5.11 branch April 9, 2025 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release Pertaining to a software release sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants