-
Notifications
You must be signed in to change notification settings - Fork 15
add: ETCM-9734 caching for governed map data #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7f4d345
to
3574a17
Compare
d9982ea
to
a2c1d27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment on the cache safety. I think we're missing some checks. My suggestion is to avoid the issue completely and just replace the cache on every miss, this is what we're doing with native tokens and I don't see a scenario where having more complex cache extension logic makes has any substantial benefits.
a2c1d27
to
47cf50f
Compare
7748214
to
76d08af
Compare
The cache is completly replaced every time now.
76d08af
to
faeba66
Compare
Description
link
Adds Cached GovernedMap DataSource implementation, and uses it in demo-node
Checklist
changelog.md
for affected crate