-
Notifications
You must be signed in to change notification settings - Fork 44
Fix: Simplify TestHttpServer
Drop
logic to prevent test flakiness
#2495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Results 3 files ±0 77 suites ±0 14m 12s ⏱️ - 1m 9s For more details on these failures, see this check. Results for commit eb9b803. ± Comparison against base commit 2b88e17. ♻️ This comment has been updated with latest results. |
09fc141
to
cff69a8
Compare
bf434a8
to
5df4c69
Compare
5df4c69
to
f98300d
Compare
TestHttpServer
to reduce test flakinessTestHttpServer
Drop
logic to prevent test flakiness
f98300d
to
c2db17f
Compare
c2db17f
to
eb9b803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
49f2cf0
to
46d2967
Compare
Content
This PR includes an update to the
Drop
implementation ofTestHttpServer
, removing therecv_timeout
call that was previously used to wait for the server thread to signal its shutdown.This change fixes flakiness in CI tests, likely caused by the blocking behavior of
block_on
, which can delay the server thread's shutdown signal.Pre-submit checklist