feature(elements): implement ino-selection #1061
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- virtualScroll not working
- add initVirtualScroll after results are shown - (virtual scroll doesn't work right now)
- add createOption feature - remove example options to storybook - make options required - rename `optionList to optionListAnchor`
- add styling - add search icon in input
- add slot for custom popover trigger - alter playground to use a chip as trigger - add placement to playground - center align playground
- add Props `controlled`, `visible` - add Event `selectionVisibleChanged` - add Story for controlled selection - edit Story to not double trigger `valueChange` on selection - `initSelection` breakdown into `handleVisibleChange` & `initSelection`
- empty inputs on closing dialog
-`Debounce`, -`noPotionText` - `Disabled` - `Placement` - `For` - `Label` - `StayOpen` - `Value`
- remove unused props from code snippets - add default values to ino-selection - make Story `for` work - remove options from Story `noOptionText` - change label for Story `debounce`
- add valueAccessor fro angular & vue - remove tanStack
- add tests - remove @watch on options - fix typo in stories
- allows to run individual test-files
- add DisplayAddOptions Story - fix style for `displayAddOptions = false`
- remove default dynamic `createOptionLabel` with `searchTerm` - add story for `createOptionLabel` with dynamic label - remove prop `open` because the same as `visible` - rename `displayAddOptions` to `hideCreateOption` - remove prop `emptyInputMessage`
- edit behaviour on valueChange - edit story & prop `value` - fix tests - remove input styling
This reverts commit 1cde882.
janivo
requested changes
Sep 21, 2023
| return; | ||
| } else { | ||
| if (popoverIsVisible) { | ||
| this.inoPopoverEl.visible = true; |
There was a problem hiding this comment.
Could better be handled as @State?
Comment on lines
+177
to
+184
| if (this.stayOpen) { | ||
| // set focus on autocomplete to keep resultList from closing | ||
| this.inoInputEl.focus(); | ||
| return; | ||
| } | ||
|
|
||
| this.inoPopoverEl.visible = false; | ||
| this.resetInput(); |
There was a problem hiding this comment.
Even if stayOpen=true the resetInput() method should still be called, shouldn't it?
janivo
force-pushed
the
master
branch
5 times, most recently
from
587f535 to
0b42a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #985
Proposed Changes
ino-selectionyarn test ino-selectionoverflow: hiddento.tippy-boxin shared style forino-popover&ino-tooltipBildschirmaufnahme.2023-09-19.um.17.52.09.mov