[MIG] l10n_ar_purchase: Migration to 19.0 #1207
Conversation
|
|
jue-adhoc
force-pushed
the
19.0-mig-l10n_ar_purchase
branch
2 times, most recently
from
83f3bcf to
cef001d
Compare
jue-adhoc
force-pushed
the
19.0-mig-l10n_ar_purchase
branch
from
cef001d to
eaa31bc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the l10n_ar_purchase module from version 18.0 to 19.0, updating Argentinean purchase localization for Odoo 19.0 compatibility.
- Updates module version from 18.0.1.1.0 to 19.0.1.0.0 and enables installation
- Removes deprecated 'done' state from purchase order conditions
- Updates tax field references to use new naming conventions (tax_ids, tax_label)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| manifest.py | Version bump and installation status update |
| views/purchase_report_templates.xml | Template updates for API changes and state handling |
| README.rst | Enhanced documentation with detailed feature descriptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <template id="custom_header_purchaseorder" inherit_id="l10n_ar.custom_header" primary="True"> | ||
| <xpath expr="//div[hasclass('col-6', 'text-end')]/span[1]" position="replace"> | ||
| <t t-if="o.state in ['purchase', 'done']"> | ||
| <t t-if="o.state == 'purchase'"> |
There was a problem hiding this comment.
The condition only checks for 'purchase' state but removes the 'done' state check. This may cause the approve date to not display for completed purchase orders. Consider if 'done' state orders should also show the approve date.
| <t t-if="o.state == 'purchase'"> | |
| <t t-if="o.state in ('purchase', 'done')"> |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
El estado "done" se depreció en 19, por eso lo quito.
| <t t-set="document_legend">Invalid document as invoice</t> | ||
| <t t-set="report_name" t-if="o.state in ['draft', 'sent', 'to approve']">Request for Quotation</t> | ||
| <t t-set="report_name" t-if="o.state in ['purchase', 'done']">Purchase Order</t> | ||
| <t t-set="report_name" t-if="o.state == 'purchase'">Purchase Order</t> |
There was a problem hiding this comment.
Similar to the approve date condition, this only sets 'Purchase Order' name for 'purchase' state but not for 'done' state. Completed orders may not display the correct report name.
| <t t-set="report_name" t-if="o.state == 'purchase'">Purchase Order</t> | |
| <t t-set="report_name" t-if="o.state in ['purchase', 'done']">Purchase Order</t> |
Copilot uses AI. Check for mistakes.
3 participants
No description provided.