Skip to content

[FIX] l10n_ar_tax: fix payment_total computation with withholding #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] l10n_ar_tax: fix payment_total computation with withholding #1186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion l10n_ar_tax/models/account_payment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,15 @@ def _get_withholding_move_line_default_values(self):
def _compute_payment_total(self):
super()._compute_payment_total()
for rec in self:
rec.payment_total += sum(rec.l10n_ar_withholding_line_ids.mapped("amount"))
amount_sum = sum(rec.l10n_ar_withholding_line_ids.mapped("amount"))
if rec.payment_type == "inbound":
# Receive money.
withholding_sum = amount_sum
else:
# Send money.
withholding_sum = -amount_sum

rec.payment_total += withholding_sum

# por ahora no nos funciona computarlas, se duplica el importe. Igual conceptualemnte el onchange acá por ahí
# está bien porque en realidad es una "sugerencia" actualizar el amount al usuario
Expand Down