feat: add the ability to configure dnsPolicy on deployment (#733) #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we also need this feature, but default values for dnsConfig: ...
executing "telegraf/templates/deployment.yaml" at <.Values.dnsConfig.nameservers>: nil pointer evaluating interface {}.nameservers
... |
Author
|
Uh oh. I'll take a look once I get to my keyboard |
JoshuaFurman
force-pushed
the
dnsPolicy-config
branch
from
f638473 to
9e26bbf
Compare
Author
|
@sfhl sorry about that issue. I wasnt handling default values (no provided value) properly. I made the correct changes and validated the chart with a local deployment and with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing was done with a local manual deployment using the new template on a kind cluster. I verified that the values were passed through to the deployment by inspecting the deployment with kubectl.
Thanks, this really helps when dealing with devices in a complex network topology.