Skip to content

Conversation

FatMii
Copy link
Contributor

@FatMii FatMii commented Sep 17, 2025

What problem does this PR solve?

About issue #10140

In version 0.20.1, we implemented the generation of new node through mouse drag and drop. If we could create a workflow module like in Coze, where there is not only a dropdown menu but also an intermediate node (placeholder node) after the drag and drop is completed, this could improve the user experience.

Type of change

  • New Feature (non-breaking change which adds functionality)

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 💞 feature Feature request, pull request that fullfill a new feature. labels Sep 17, 2025
@FatMii
Copy link
Contributor Author

FatMii commented Sep 17, 2025

Hi team, I've submitted a PR for issue #10140 .

Could you please take a look when you have time? Thanks! @KevinHuSh @ZhenhangTung

@FatMii FatMii changed the title feat: Keep connection status during generating agent by dra and drop … feat: Keep connection status during generating agent by drag and drop … Sep 17, 2025
@yingfeng yingfeng added the ci Continue Integration label Sep 18, 2025
@cike8899
Copy link
Contributor

image

There should be no placeholder node when clicking the anchor point. @FatMii

@FatMii
Copy link
Contributor Author

FatMii commented Sep 18, 2025

image There should be no placeholder node when clicking the anchor point. @FatMii

Thanks for your reply! got it and currently fixing this bug.... @cike8899

@cike8899
Copy link
Contributor

The coordinates of the placeholder node and the real node have a large offset. @FatMii

@FatMii
Copy link
Contributor Author

FatMii commented Sep 18, 2025

The coordinates of the placeholder node and the real node have a large offset. @FatMii

Yes. 😅
At present, the coordinates of the real node are still the same as the dropdown component, and this problem will be fixed together in the next commit 🤠 @cike8899

@KevinHuSh KevinHuSh changed the title feat: Keep connection status during generating agent by drag and drop … Feat: Keep connection status during generating agent by drag and drop … Sep 18, 2025
@KevinHuSh KevinHuSh removed the ci Continue Integration label Sep 18, 2025
@FatMii
Copy link
Contributor Author

FatMii commented Sep 18, 2025

image There should be no placeholder node when clicking the anchor point. @FatMii

I am unable to reproduce the situation you described. Can you provide me with stable steps for reproducing or a demonstration of the operation? @cike8899
3

Is it possible that you lightly moved the mouse while clicking within the anchor point?

@FatMii
Copy link
Contributor Author

FatMii commented Sep 18, 2025

The coordinates of the placeholder node and the real node have a large offset. @FatMii

It has been fixed in the latest commit(#61ec01f) @cike8899

@cike8899 cike8899 added the ci Continue Integration label Sep 19, 2025
@KevinHuSh KevinHuSh requested a review from cike8899 September 19, 2025 07:38
@cike8899
Copy link
Contributor

cike8899 commented Sep 24, 2025

image There should be no placeholder node when clicking the anchor point. @FatMii

The problem still exists. @FatMii

@FatMii
Copy link
Contributor Author

FatMii commented Sep 27, 2025

image There should be no placeholder node when clicking the anchor point. @FatMii

The problem still exists. @FatMii

Please use the latest code to test if the issue still exists. If it still exists, please provide me with the logs in the console (starting with [DEBUG]). I would greatly appreciate it. @cike8899

@cike8899
Copy link
Contributor

cike8899 commented Sep 28, 2025

image Click the plus sign to add an operator, the connection disappears and the coordinates are incorrect. image

@FatMii

@FatMii
Copy link
Contributor Author

FatMii commented Sep 28, 2025

image Click the plus sign to add an operator, the connection disappears and the coordinates are incorrect. image
@FatMii

Hi @cike8899 ,
First of all, I'm really sorry for the delay in fixing this. I had some trouble reproducing the issue locally because my environment was using a different version of @xyflow/react (not 12.3.6).
Now that I've identified the root cause and matched the correct version, I've fixed the bug. Could you please take another look at the PR when you have time? Thank you for your patience and understanding!

@KevinHuSh KevinHuSh merged commit 8426cbb into infiniflow:main Sep 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continue Integration 💞 feature Feature request, pull request that fullfill a new feature. size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants